Make all the static files path absolute. #1219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because, if we don't do it all the paths will be relative to the current URL and whenever we want to render a notebook view from the paths other than the root URL of /, the static files path get appended to that path from where we are asking for static files and since static files are not mapped to those URLs we get HTTP 404 on all those static files. For example: If we render a notebook view from say /kernels/kernel-4444.json, the static files will be looked at /kernel/static/... without this patch. But after applying this, irrespective of which URL we are at, the static files will be looked up at /static/...
|
I believe PR #1211 already makes this change. |
|
Ah right. I did not look at it. Sorry about it. I am closing this pull request then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because, if we don't do it all the paths will be
relative to the current URL and whenever we want to render a notebook
view from the paths other than the root URL of /, the static files path
get appended to that path from where we are asking for static files and
since static files are not mapped to those URLs we get HTTP 404 on all
those static files.
For example: If we render a notebook view from say /kernels/kernel-4444.json,
the static files will be looked at /kernel/static/... without this patch.
But after applying this, irrespective of which URL we are at, the static
files will be looked up at /static/...