Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in notebooklist.js breaks links #1254

Closed
juliantaylor opened this issue Jan 11, 2012 · 3 comments
Closed

typo in notebooklist.js breaks links #1254

juliantaylor opened this issue Jan 11, 2012 · 3 comments
Labels
bug notebook
Milestone
0.13

Comments

@juliantaylor
Copy link
Contributor

frontend/html/notebook/static/js/notebooklist.js:115
has baseProjectURL whereas the rest of the file file uses baseProjectUrl

which breaks the links in the list in some cases, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655413
@juliantaylor
Copy link
Contributor Author

@minrk can this fix please be added to the 0.12.1 branch, thanks

@minrk
Copy link
Member

minrk commented Apr 11, 2012

I may not be able to make a commit for 48 hours, but any IPython dev can do this. @fperez @ellisonbg @takluyver if you have a minute.

takluyver added a commit that referenced this issue Apr 11, 2012
@takluyver
Fix typo in notebook list javascript
cb7ff56 
See gh-1254
@takluyver
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug notebook
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
4 participants
@ellisonbg @minrk @takluyver @juliantaylor