Dewijmoize #1256
Dewijmoize #1256
Conversation
|
OK I have fixed printing. I have created a new "Print View" that prints nicely. This needs solid testing on multiple browsers, with and without login enabled. |
|
|
||
| @authenticate_unless_readonly | ||
| def get(self, notebook_id): | ||
| nbm = self.application.notebook_manager |
There was a problem hiding this comment.
I think we should start putting docstrings on these guys. I know in the beginning the whole nb code was so massive that we couldn't be too detailed with this, but before we end up with a ton of undocumented code, having a short explanation on these guys would be useful.
There was a problem hiding this comment.
I think it is too early to start documenting things like this. All of these handlers are going to get completely redone in the near future. Don't get me wrong - I do think documenting things like this is important once the code settles down.
|
This looks great. I've played with it in use, and it's a massive improvement. I'll continue using this as my working branch to test it out more carefully, but it's looking great so far. Once printing is fixed, I think we can move quickly forward with it. Great job! |
|
Printing IS fixed now... On Wed, Jan 11, 2012 at 10:45 PM, Fernando Perez
Brian E. Granger |
|
On Wed, Jan 11, 2012 at 10:45 PM, Brian E. Granger
Ah great! Since the description said it wasn't, I didn't realize the But I noticed one problem with printing: if a markdown cell has a |
|
On Wed, Jan 11, 2012 at 10:52 PM, Fernando Perez
Can you change that to src="/files/..." to make it absolute? It
Brian E. Granger |
|
On Wed, Jan 11, 2012 at 11:00 PM, Brian E. Granger
Changed, same problem... |
|
Can you double check this. I just made the change in the notebook On Wed, Jan 11, 2012 at 11:04 PM, Fernando Perez
Brian E. Granger |
* QuickHelp button has been removed in favor of a Help menu item. * Keyboard shortcuts are now in the menus. * Numerous fixes to subtle aspects of the wijmenu implementation.
There is not a rename dialog that is available in the File menu and when you click on the notebook name.
* Added last saved with time/date display. * Reimplemented save widget status updates.
|
@fperez, can you check printing on Linux. It works fine on Mac now - except there is a bug in Chrome's print dialog that is crashing the print view tab in some cases. But Firefox and Safari look great. |
|
Brian, I'm still seeing problems with a specific notebook. It prints fine with master, so it's something specific to this branch. Go to my tmp directory and download both the ipynb and the svg file. This nb prints fine for me with master on both ffox and chrome (linux), but with this branch, neither browser can print it. Ffox simply ignores the image, and Chrome shows a big 'broken image' area. |
|
@fperez: you still had the files URL relative "files/..." once I made On Thu, Jan 12, 2012 at 3:40 PM, Fernando Perez
Brian E. Granger |
|
On Thu, Jan 12, 2012 at 3:48 PM, Brian E. Granger
Argh, I could have sworn I'd changed that last night!!! But I Yes, it now works fine, from both FFox and Chrome. Sorry for the confusion. Anything else we need before we can merge this one? It's looking |
|
On Thu, Jan 12, 2012 at 3:56 PM, Fernando Perez
No I think that is it. Thanks for the reviews and testing. I will merge it...
Brian E. Granger |
A jQueryUI based menu drived UI. Other aspects of the notebook have been improved as well:
Before this can be merged though, we need to fix the printing, which broke in moving to the menu. But please start to review as the printing will be fixed soon.