Heartbeat no longer shares the app's Context #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the heartbeat from ever waiting for the GIL, which could cause erroneous heartbeat failures.
|
This fixes looks quite simple and it looks ready for merging. Thanks again for tracking this down! |
|
I just realized that this obviously can also affect the parallel engines, so I'll make the same change there before merging. |
|
Similar tiny change in parallel, merging shortly. |
minrk
added a commit
that referenced
this pull request
Jan 14, 2012
Heartbeat no longer shares the app's Context Fixes in both the single and parallel kernels, preventing the heartbeat thread from sharing the zmq Context with the rest of the process. Non-copying sends require grabbing the GIL from the zmq io-thread in order to free memory, which could let Python get in the way of the heartbeat. Test script and notebook added to examples directory. closes #1260
minrk
added a commit
that referenced
this pull request
Jan 18, 2012
Heartbeat no longer shares the app's Context Fixes in both the single and parallel kernels, preventing the heartbeat thread from sharing the zmq Context with the rest of the process. Non-copying sends require grabbing the GIL from the zmq io-thread in order to free memory, which could let Python get in the way of the heartbeat. Test script and notebook added to examples directory. closes #1260
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Heartbeat no longer shares the app's Context Fixes in both the single and parallel kernels, preventing the heartbeat thread from sharing the zmq Context with the rest of the process. Non-copying sends require grabbing the GIL from the zmq io-thread in order to free memory, which could let Python get in the way of the heartbeat. Test script and notebook added to examples directory. closes ipython#1260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the chosen solution 2. in #1260. I couldn't see any of the extra bookkeeping that I thought might be necessary, so simply creating a new context is all there was to do.
Test script and notebook added to examples directory for easier confirmation, as described in #1127
closes #1260