New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aceify #1264
Aceify #1264
Conversation
@fperez: I think I have fixed the issue you were seeing. Please give it a try and let me know. |
This is great! I like it a lot, and I can see moving forward this providing also support for editing .py files in the notebook directory (and even others). This would be great for teaching scenarios where we've always struggled with the 'what editor do I use' question, as well as for remote usage where everything could be done via ipython regarding managing of normal scripts, shell scripts, etc. So a big +1 to the whole thing. A few things I've noticed in quick testing, I don't know how easy they will be to fix:
The first two issues I think we should really fix before merging. The others are icing on the cake, and I'm fine if they have to wait for improvements in Ace itself (though obviously it would be great to get them done if possible). Great job in all! |
Fonts: good catch, should be a simple fix. |
Sounds good. It's a bummer the tab completion is complex to fix, but such is life. I agree, much better to leave as a separate issue to refactor and clean up that code to a point in which it can be easily reused from either the CM or Ace cells. Re. keybindings, the only ones I've found so far are Tab/Shift Tab for indent/dedent (you told me these), C-f for find, C-r for search & replace. There may be others :) I also saw on their site that they have emacs/vi modes, having this as a menu option would be great. Having a vi mode will really appeal to the vi true believers, b/c for them editing in 'normal' editors is so different from their muscle memory. Though if exposing that configurability is best done once we have tackled the more generic config question in the browser, that's ok too. |
* The editor won't get focus on some browsers (Chrome/FF on Linux and Safari on Mac). Latest dev master seems better but the issue still shows up sometimes. Adding a manual window.resizeBy fixes this for now.
* Font size and family matches that of our CodeMirror editors. * Help link to Ace keyboard shortcuts added to help.
I have opened a ticket for the refactoring of the tab completion/tooltip stuff: #1287 I have matched the fonts to the CodeMirror editors. I have added a link in our help menu to the Ace keyboard shortcuts (there are tons of them!). |
Added the ability to edit a single code cell nearly full screen in an Ace editor. Ace is a more full featured code editor than CodeMirror, but you can only have one on a page, so we can't use it for cells. This should improve the use experience when working with large code cells. In the long run we can add different configuration
options to this editor.