a fix for GH 1269 #1284
Merged
a fix for GH 1269 #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Looks sensible to me. I imagine we are likely to run into this sort of thing a few more times before we rewrite the magic arg-splitting in a cleaner way. The process_common thing is a bit funky - we really should not be using the same code to split magic arguments and split strings into a Popen command-list, but we do, so your fix is probably in the right place. That's more for the major reorganization of magics that @fperez has in mind. |
|
needs a quick rebase, due to some unfortunate cleanup that had to be done in master. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
a fix for GH ipython#1269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a test and fix for #1269. I originally thought the fix was going to be in
magic.py, and went ahead and fixed the typos in that file, but it turned out that the fix ended up going into_process_common.py- hope that's ok.