Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the notebook tab completion/tooltip #1287

Closed
ellisonbg opened this issue Jan 18, 2012 · 3 comments
Closed

Refactor the notebook tab completion/tooltip #1287

ellisonbg opened this issue Jan 18, 2012 · 3 comments
Labels
Milestone

Comments

@ellisonbg
Copy link
Member

Currently, the tab completion logic and tooltips are in the CodeCell. This is quite messy code and it is welded to the CodeMirror implementation. This logic needs to be cleaned up and put into a separate Completer class that can be used with both CodeMirror and Ace. When this is done there are other things that should be cleaned up. The css of the tooltip needs to be simplified and converted to use jQueryUI theming, css and animation support.

@ellisonbg ellisonbg mentioned this issue Jan 18, 2012
@fperez
Copy link
Member

fperez commented Jan 18, 2012

@ellisonbg, did you really mean to close this issue?

@ellisonbg
Copy link
Member Author

It is still open no? The closed link if for the PR #1264 that I referenced the issue from.

@fperez
Copy link
Member

fperez commented Jan 18, 2012

Argh, never mind. I got confused by the closed link about the PR and misread it as closing the issue. Sorry for the noise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants