Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyreadline workarounds, we now require pyreadline >= 1.7.1 #1307

Closed
fperez opened this issue Jan 21, 2012 · 0 comments · Fixed by #3487
Closed

Remove pyreadline workarounds, we now require pyreadline >= 1.7.1 #1307

fperez opened this issue Jan 21, 2012 · 0 comments · Fixed by #3487
Labels
good first issue windows
Milestone
1.0

Comments

@fperez
Copy link
Member

fperez commented Jan 21, 2012

After #1301, on Windows we explicitly require pyreadline >= 1.7.1, so we can clean things up and remove workarounds we had in a few places that only mattered for 1.5 or 1.6.
takluyver added a commit to takluyver/ipython that referenced this issue Jun 29, 2013
@takluyver
Drop patch for compatibility with pyreadline 1.5
bdc95ea 
Closes ipythongh-1307
@takluyver takluyver mentioned this issue Jun 29, 2013
Merged
minrk added a commit that referenced this issue Jul 15, 2013
@minrk
Merge pull request #3487 from takluyver/drop_old_pyreadline
554fc32 
Drop patch for compatibility with pyreadline 1.5

Closes #1307
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@takluyver
Drop patch for compatibility with pyreadline 1.5
c1bda6c 
Closes ipythongh-1307
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#3487 from takluyver/drop_old_pyreadline
83a46f9 
Drop patch for compatibility with pyreadline 1.5

Closes ipython#1307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue windows
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Drop patch for compatibility with pyreadline 1.5 takluyver/ipython
1 participant
@fperez