minor heartbeat tweaks #1312
Merged
minor heartbeat tweaks #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents mismatch between heartbeat timer and actual heartbeat send/recv events. Applied in notebook and parallel.
Matches heartbeats elsewhere. 3s should be extremely conservative, as most heartbeat responses are O(1ms).
|
This looks good - I think it can be merged. |
minrk
added a commit
that referenced
this pull request
Jan 23, 2012
two small heartbeat changes: * flush outgoing heartbeats (notebook and parallel): - Prevents mismatch between heartbeat timer and actual heartbeat send/recv events. * relax default heartbeat period in IPython.parallel to 3s from 1s - Matches heartbeats elsewhere. 3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues). closes #1304
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
two small heartbeat changes: * flush outgoing heartbeats (notebook and parallel): - Prevents mismatch between heartbeat timer and actual heartbeat send/recv events. * relax default heartbeat period in IPython.parallel to 3s from 1s - Matches heartbeats elsewhere. 3s should be extremely conservative, as most heartbeat responses are O(1ms) unless there's a bug in our code (like the above flush and previously-discovered GIL issues). closes ipython#1304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two small changes:
closes #1304