crack at making notebook.html use the layout.html template #1336
Conversation
| data-project={{project}} data-notebook-id={{notebook_id}} | ||
| data-base-project-url={{base_project_url}} data-base-kernel-url={{base_kernel_url}} | ||
| > | ||
|
|
||
| <div id="header"> |
There was a problem hiding this comment.
I see this whole block deleted here but it doesn't appear anywhere else. Was it redundant/duplicate code?
|
well, since we now extend layout.html, we get that header div from layout.html (i tried to write that html in this txtbox, but it gets escaped away.... |
|
Got it. Thanks for the clarification. |
|
OK, everything looks good to me, but since this code was initially laid out by @ellisonbg and he's in the middle of working with it, I'd like to give him a chance to have a quick look before merging. But in testing it seems to work OK, and the code simplification is certainly good. Thanks! |
|
I can merge this once @ellisonbg gives his final OK. |
|
Sorry, but this needs to be rebased again... |
|
|
||
| {% end %} | ||
|
|
||
| {% block header %} | ||
| {% end %} | ||
| </div> | ||
|
|
||
| <div id="header_border"></div> |
There was a problem hiding this comment.
header_border should not be in layout - it is only part of some pages.
Conflicts: