Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last lines in long cells are hidden #1373

Closed
ghost opened this issue Feb 3, 2012 · 6 comments
Closed

Last lines in long cells are hidden #1373

ghost opened this issue Feb 3, 2012 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 3, 2012

When opening a notebook in 0.12 (htmlnotebook, chromium 16) last lines of long cells get "cut". They still are there but they are covered by the white margin delimiting cells. Looks like the font is just a little too big for the space it is designed to fit. I believe it is something around 1 line missing per 20-30 lines of code.

I also tried current dev version and it is still there. What's more the cursor does not follow the texts but the imaginary lines. At the end of the cell, cursor is half way between lines, but typed letters appear in the half-covered line.

Sorry if that is not really clear but it is quite hard to describe.

EDIT:
As a picture is probably worth more than a thousand words in this case, here's the photo: http://goo.gl/qcglG

Also I discovered that the problem is caused by bolded words. A cell without these, no matter how long, is displayed properly.

@tburnett
Copy link

tburnett commented Feb 4, 2012

I have noticed this too. For me, it depends on adjusting the zoom factor. For full, 100%, zoom, there is no problem.
Since I really like to set zooms less that 100%, it would be nice not to have this distraction.

@twmr
Copy link
Contributor

twmr commented Feb 4, 2012

I also noticed it. Another issue is that the Insertion point (text cursor) is not centered (vertically) on certain lines of long cells if the zoom factor is not 100%! This makes it hard to know where text gets inserted.

@ghost
Copy link
Author

ghost commented Feb 4, 2012

After further investigation I found two things.

First, this is only a problem in chromium-based browsers. When starting notebook in Firefox the issue is miraculously gone.
Second, after diminishing and enlarging (but not after enlarging and diminishing) back to 100%, the issue is gone in Chromium.

Can anyone confirm what I've found?

@ellisonbg
Copy link
Member

I think the fix will be to call code_mirror.refresh on resize events. But this could be a bug in CodeMirror itself in their calculation of the editor size when the scale is not 100%.

@minrk
Copy link
Member

minrk commented Jan 19, 2013

@rrrsadowski @thisch can you check if this still affects master? I cannot reproduce it.

@minrk
Copy link
Member

minrk commented Jun 19, 2013

Closing as addressed by updating CodeMirror. Can reopen if anyone can actually reproduce it.

@minrk minrk closed this as completed Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants