Only monkeypatch xunit when the tests are run using it. #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Are there any other reasonable ways to invoke xunit without that particular flag? |
|
I'm not sure, but we're not using any others, and other code in iptest already looks for that command-line flag. |
|
Fair enough, merging then. |
minrk
added a commit
that referenced
this pull request
Feb 13, 2012
Only monkeypatch xunit when the tests are run using it. Sidesteps weird issues seen on Ubuntu buildbots.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…equest Only monkeypatch xunit when the tests are run using it. Sidesteps weird issues seen on Ubuntu buildbots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on #1395