ignore errors in shell.var_expand #1414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is raised in the formatter, leave it untransformed. This means that var_expand("$foo") will return "$foo" if
foo
is undefined, but more importantly it will not raise when var_expand is used on literal code that doesn't expect to be expanded (e.g. %prun arguments).A few tests included.
The real answer to this problem is to not call var_expand where it shouldn't be called, just as with the argument split. We really treat all magics as shell options, and we shouldn't, but until we get that whole logic cleaned up, this is a temporary solution. The only drawback is that
ls $files
will result inls $files
instead of NameError iffiles
is undefined, which is the most logical behavior. But valid calls to%prun
are more important than raising the right error in invalid calls tols
.closes #1412