Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook not storing heading celltype information #1439

Closed
joonro opened this issue Feb 26, 2012 · 5 comments · Fixed by #1451
Closed

Notebook not storing heading celltype information #1439

joonro opened this issue Feb 26, 2012 · 5 comments · Fixed by #1451

Comments

@joonro
Copy link
Contributor

joonro commented Feb 26, 2012

Whatever heading number I give to a cell, notebook is not saving the information.

For example, when I look at the saved .ipynb file, regardless of the heading number, all of them have

"cell_type": "heading",

instead of

"cell_type": "heading 2"
@ellisonbg
Copy link
Member

Hmm, OK I will have a look at this. Thanks.

On Sun, Feb 26, 2012 at 8:05 AM, joonro
reply@reply.github.com
wrote:

Whatever heading number I give to a cell, notebook is not saving the information.

For example, when I look at the saved .ipynb file, regardless of the heading number, all of them have

"cell_type": "heading",

instead of

"cell_type": "heading 2"

Reply to this email directly or view it on GitHub:
#1439

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member

minrk commented Feb 26, 2012

cell type should be 'heading' for all of these, and 'level' should be a variable attribute.

@joonro
Copy link
Contributor Author

joonro commented Feb 26, 2012

Then I guess notebook is not saving the level attribute. I just tried again and I've got

     {
     "cell_type": "heading",
     "source": [
      "heading test with heading 2"
     ]
    },

in the .ipynb file for the corresponding cell. (I've set it as heading 2)

@minrk
Copy link
Member

minrk commented Feb 28, 2012

see PR #1451 for fix

@fperez fperez closed this as completed in 5c23e25 Feb 28, 2012
@joonro
Copy link
Contributor Author

joonro commented Feb 28, 2012

Thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Include heading level in JSON. Closes ipython#1439.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants