Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhide git_commit_info.ini #1524

Closed
wants to merge 1 commit into from

Conversation

juliantaylor
Copy link
Contributor

installing hidden files in system paths is bad style
closes #1484

installing hidden files in system paths is bad style
closes ipython#1484
@fperez
Copy link
Member

fperez commented Mar 26, 2012

This file is only for internal use and is not a python file, so I don't really see the need to have it visible. 'Bad style' is sometimes a matter of preference, and I don't like to see our code directories cluttered, esp. the main IPython one. So I'm -1 on merging this.

@juliantaylor
Copy link
Contributor Author

how about moving it to a different directory?

@minrk
Copy link
Member

minrk commented Mar 26, 2012

We put everything that code actually needs in the IPython source dir, because Python has no reliable answer for finding files that end up elsewhere.

FWIW, I'm +1 on not having hidden files in the source tree, and I think we should either unhide it (and possibly move it adjacent to utils/sysinfo, where it is used), or write the info into the Python file itself, as done in numpy.

@fperez
Copy link
Member

fperez commented Mar 26, 2012

In that case, let's find a solution that doesn't require another file or let's put it next to utils/sysinfo. I haven't looked at what numpy is doing these days, but if that's simple enough to copy, I'd be fine with it.

@minrk
Copy link
Member

minrk commented Mar 26, 2012

numpy is doing pretty much the exact same thing we are, but they write a Python file instead of hidden ini.

their code

@fperez
Copy link
Member

fperez commented Apr 14, 2012

I'm going to close this and we'll go with #1538 instead, which I think is a cleaner solution in the long run. Let us know if you see anything missing there for your purposes, @juliantaylor.

@fperez fperez closed this Apr 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unhide .git_commit_info.ini
3 participants