Function keyword completion fails if cursor is in the middle of the complete parentheses

[piti118]

This PR fix this issue

hist(c<tab>

This will suggest function keyword argument completion like color etc.
However, (note the last parenthesis)

hist(c<cursor here, tab>)

This does not suggest the function keyword argument completion even though it should.

[takluyver]

Well spotted! I'll test this out later.

[fperez]

This looks good, but before we merge it, we should add a test that fails when the fix isn't present but succeeds after it. @piti118, the completer machinery already has some tests, so it shouldn't be too hard to add one more. But do let us know if you need a hand with it, and we'll be happy to help.

That way, we'll ensure that in the future this problem doesn't reappear as the code evolves.

Thanks for your contribution, @piti118!

[piti118]

stupid question but... how do I run the existing test?

[fperez]

Use the iptest command, which can be given arguments to run just some tests. The developer docs have more details on how to run tests in general; let us know if you have any trouble with it and we'll be happy to help out.

[piti118]

Done. Can you check it out?

[fperez]

@piti118, thanks! BTW, in general you should never merge from master into a feature branch you are doing a pull request from, as that creates nasty criss-crossing in the git history graph, making it harder to see exactly what is new to a given branch. If you need the code from master, you should instead rebase your changes on top of master.

I've done that for you this time so we could close this PR, so the commits that were merged have different hashes from yours, but keep it in mind for the future.

Thanks again for the contribution!