Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook should be saved before printing #1551

Closed
jstenar opened this issue Apr 4, 2012 · 4 comments
Closed

Notebook should be saved before printing #1551

jstenar opened this issue Apr 4, 2012 · 4 comments
Milestone

Comments

@jstenar
Copy link
Member

jstenar commented Apr 4, 2012

When using the print preview I get the last saved version of the notebook and not the version that I'm currently editing.

Using master 75fa2b8 on windows 7 python2.7

@minrk
Copy link
Member

minrk commented Apr 4, 2012

Note that this is not just print-preview. I believe it is all of the methods that fetch the notebook from the server - download, print, etc.

@ihnorton
Copy link

A related bug is that if I attempt to "download as" a notebook as .ipynb between auto-saves, then I get an "are you sure you want to leave this page" warning (firefox 23, ubuntu 13.04). The download attempt seems to trigger an auto-save the next time, but it would be nice to have it happen first and avoid the warning.

@ArcTanSusan
Copy link
Contributor

I cannot replicate this bug.

  1. The print button is no longer on the menu bar in the notebook.
  2. Also, "Download As" menu dropdown button already has a "save notebook" event handler: https://github.com/ipython/ipython/blob/master/IPython/html/static/notebook/js/menubar.js#L90

@minrk
Copy link
Member

minrk commented Dec 13, 2013

Thanks for noticing, this has indeed been fixed.

@minrk minrk closed this as completed Dec 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants