Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ipython testing documentation still mentions twisted and trial #1558

Closed
jenshnielsen opened this issue Apr 7, 2012 · 2 comments · Fixed by #1560
Closed

Ipython testing documentation still mentions twisted and trial #1558

jenshnielsen opened this issue Apr 7, 2012 · 2 comments · Fixed by #1560
Labels
documentation
Milestone
0.13

Comments

@jenshnielsen
Copy link
Contributor

The IPython testing documentation http://ipython.org/ipython-doc/dev/development/testing.html
still mentions twisted tests and the trial test runner.
I guess this should be removed since IPython no longer uses twisted?
@minrk minrk mentioned this issue Apr 7, 2012
Merged
@minrk
Copy link
Member

minrk commented Apr 7, 2012

thanks, PR #1560 should take care of that.

@jenshnielsen
Copy link
Contributor Author

Thanks looks good. One small thing line 87 still mentions twisted (the libraries available at test time)

@fperez fperez closed this as completed in 415b530 Apr 14, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@fperez
Merge pull request ipython#1560 from minrk/testdocs
ef307c6 
remove obsolete discussion of Twisted/trial from testing docs

We don't use trial anymore, so these docs were no longer accurate.

closes ipython#1558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

remove obsolete discussion of Twisted/trial from testing docs minrk/ipython
3 participants
@fperez @minrk @jenshnielsen