Fix: openssh_tunnel did not parse port in server

[tkf]

Despite what the docstring of openssh_tunnel mentioned, it did not parse
username in port in the server argument. This patch fixes the problem
so that ipython client can connect to the server over port-forwarded ssh
connection. For example, you can connect the client by the following
code now::

  c = Client('/path/to/ipcontroller-client.json',
             sshserver='me@localhost:1234')

[minrk]

Thanks!

[minrk]

Crap, this actually broke another case (implicit username from .ssh/config). I'll push a fix shortly.

[tkf]

Thanks for the super fast pull!

I was a little bit uneasy for adding username and port automatically. Maybe it is possible to set port in .ssh/config also? I was unaware of the implicit case.

[minrk]

Can you check if your case still works after #1568?

[minrk]

Yes, the code would have worked before if you had simply configured .ssh/config with your username and port. Now, with PR #1568, it properly only specifies the parts you are specifying. For instance, I have various user/server/port combos set up in my sshconfig, and then I can just pass their ssh alias to the Client constructor.

[tkf]

Yes your fix worked in my setup.

BTW, do you know if some incompatibility from 0.12 introduced in the master branch? I am thinking of using the master branch in my laptop and the stable one in my clusters.

[minrk]

I think they should work together, but I'm not 100% sure. You should be able to test locally with a couple of virtualenvs.

I will do some cleanup of serialization and connection files issues that have been bugging me, and these will break compatibility with older versions, but they will not go into 0.13 (unless it is significantly delayed).

[tkf]

Yea I know, I won't blame you even it brakes my laptop. I will be aware of your connection branch. Thank you very much!

[minrk]

It will only break for users trying to use multiple versions of IPython together, in the same cluster. Everything else should be fine across the upgrade.

Just as a datapoint, what launchers (SGE/MPI/SSH) are you using on your cluster?

[tkf]

I need to use same version in the machine where I run ipcontroller and the machine where I run the client because they pass around the parameter via ipcontroller-client.json, right?

I just started using via ssh and haven't setup anything advanced yet. The controller and engines are at the same remote machine.

[minrk]

The connection files don't change from 0.11-0.13, so you should be fine. But there will be a change between 0.13/0.14. But it's always a good idea for things to match if you can help it.

[tkf]

Right, you said that your connection branch won't be in 0.13. So I suppose the connection file format won't change as long as I am on the master.