Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyreadline version dependency not correctly checked #1572

Closed
matthew-brett opened this issue Apr 11, 2012 · 1 comment · Fixed by #1935
Closed

pyreadline version dependency not correctly checked #1572

matthew-brett opened this issue Apr 11, 2012 · 1 comment · Fixed by #1935
Milestone

Comments

@matthew-brett
Copy link
Contributor

Installing IPython on windows with python setup.py install and pyreadline 1.5:

C:\code\dev_trees\ipython [main-master]> ipython
Python 2.6.5 (r265:79096, Mar 19 2010, 21:48:26) [MSC v.1500 32 bit (Intel)]
Type "copyright", "credits" or "license" for more information.

IPython 0.13.dev -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.
Traceback (most recent call last):
  File "C:\Python26\Scripts\ipython-script.py", line 9, in 
    load_entry_point('ipython==0.13.dev', 'console_scripts', 'ipython')()
  File "C:\Python26\lib\site-packages\ipython-0.13.dev-py2.6.egg\IPython\frontend\terminal\ipapp.py", line 409, in launch_new_instance
    app.start()
  File "C:\Python26\lib\site-packages\ipython-0.13.dev-py2.6.egg\IPython\frontend\terminal\ipapp.py", line 383, in start
    self.shell.mainloop()
  File "C:\Python26\lib\site-packages\ipython-0.13.dev-py2.6.egg\IPython\frontend\terminal\interactiveshell.py", line 290, in mainloop
    self.interact(display_banner=display_banner)
  File "C:\Python26\lib\site-packages\ipython-0.13.dev-py2.6.egg\IPython\frontend\terminal\interactiveshell.py", line 346, in interact
    hlen_b4_cell = self.readline.get_current_history_length()
AttributeError: 'module' object has no attribute 'get_current_history_length'

I see that setup.py requires pyreadline >= 1.7.1, iff setupext.check_for_readline() returns False. However, in my case, it returns True because the function does not check the version, and I have version 1.5. I wasn't sure how best to put the version dependency into the function.

@minrk minrk closed this as completed in ee28689 Jun 13, 2012
fperez added a commit to minrk/ipython that referenced this issue Jun 13, 2012
Add version checking to pyreadline import test, as we depend on specific pyreadline versions.

closes ipython#1572
@alexlouden
Copy link

I just installed the latest version on Windows XP 32-bit (ugh) with pip:

> pip freeze
pyreadline==1.5
ipython==0.13.1

Getting the same error as above:

...
hlen_b4_cell = self.readline.get_current_history_length()
AttributeError: 'module' object has no attribute 'get_current_history_length'

I updated pyreadline (pyreadline==2.0-dev1), which fixed it.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Add version checking to pyreadline import test, as we depend on specific pyreadline versions.

closes ipython#1572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants