Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ctrl+C crashes wx pylab kernel in qtconsole. #1573

Merged
merged 1 commit into from Apr 13, 2012

Conversation

pankajp
Copy link
Contributor

@pankajp pankajp commented Apr 12, 2012

Wx import sets the SIGINT handler to 0 so we reset it to python's
default_int_handler to handle Ctrl+C.
The following thread discusses the issue:
http://mail.scipy.org/pipermail/ipython-dev/2012-April/008942.html

Wx import sets the SIGINT handler to 0 so we reset it to python's
default_int_handler to handle Ctrl+C.
The following thread discusses the issue:
http://mail.scipy.org/pipermail/ipython-dev/2012-April/008942.html
@jdmarch
Copy link

jdmarch commented Apr 12, 2012

Fixes #1574

@prabhuramachandran
Copy link
Contributor

@ellisonbg, @fperez, @epatters -- this fixes a pretty serious bug with the qtconsole: try this:

  ipython-qtconsole --pylab=wx

Create an infinite loop and hit Ctrl-C and the prompt is lost. It would be great if this were merged ASAP, on the mac Mayavi only works on wxPython so this can be bad for someone wanting that.

@takluyver
Copy link
Member

I know very little about the event loop integration, but does the same fix need to be in the 'inputhook' system for integration with plain terminal IPython? If someone could check if the same bug affects that, that would be great.

I think this is the relevant file: https://github.com/ipython/ipython/blob/master/IPython/lib/inputhookwx.py

@prabhuramachandran
Copy link
Contributor

Yes, the inputhook already sets the signal handler correctly and in fact that was where this solution was copied over from. :) So this problem does not occur on the terminal client but only on the qtconsole.

@takluyver
Copy link
Member

Oh yes, I see that code now. No other objections.

@fperez
Copy link
Member

fperez commented Apr 13, 2012

Looks good to me too; @jdmarch merge away!

jdmarch pushed a commit that referenced this pull request Apr 13, 2012
BUG: Ctrl+C crashes wx pylab kernel in qtconsole.
@jdmarch jdmarch merged commit ca084e3 into ipython:master Apr 13, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
BUG: Ctrl+C crashes wx pylab kernel in qtconsole.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants