Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tight coupling between Notebook, CodeCell and Kernel Javascript objects #1586

Closed
ellisonbg opened this issue Apr 12, 2012 · 4 comments
Labels
Milestone

Comments

@ellisonbg
Copy link
Member

Currently, there is very tight coupling between the Notebook, CodeCell and Kernel Javascript objects in the notebook:

  • Notebook has many methods that belong in the Kernel.
  • Notebook tracks the UUID's of the pending commands.
  • CodeCell talks to the Kernel through the Notebook.

We need to decouple this mess:

  • CodeCell should only depend on Kernel, not the Notebook.
  • The Kernel execute method should track the pending commands and the callbacks for each command.
  • The Kernel should not depend on CodeCell or Notebook in any way.
  • There should be a clean API on the Kernel for executing code that can be used by Javascript widgets to run code.
@ellisonbg
Copy link
Member Author

Work ongoing in PR #1697.

@minrk
Copy link
Member

minrk commented Jun 11, 2012

This work is done, yes? I think it got decoupled from the PR as it was resubmitted with consolidation.

@ellisonbg
Copy link
Member Author

Yes, this has been merged.

On Sun, Jun 10, 2012 at 6:52 PM, Min RK
reply@reply.github.com
wrote:

This work is done, yes?  I think it got decoupled from the PR as it was resubmitted with consolidation.


Reply to this email directly or view it on GitHub:
#1586 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member

minrk commented Jun 11, 2012

Thanks, closing.

@minrk minrk closed this as completed Jun 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants