Keying 'q' doesn't quit the interactive help in Wins7

[andrewgohlk]

Hi,

When I use ? or %magic where there'll be a list of help text displayed, pressing the 'q' to quit the help text doesn't work. It will continue with the next section of help text of iPyhton3 in Wins7.

[takluyver]

To clarify, is this with IPython at a command prompt, or in the Qt console?

[andrewgohlk]

It's in the IPython command prompt. I didn't install Qt package.

In [1]: %magic
IPython's 'magic' functions
'===========================

The magic function system provides a series of functions which allow you to
control the behavior of IPython itself, plus a lot of system-type
features. All these functions are prefixed with a % character, but parameters
are given without parentheses or quotes.

NOTE: If you have 'automagic' enabled (via the command line option or with the
%automagic function), you don't need to type in the % explicitly. By default,
IPython ships with automagic on, so you should only rarely need the % escape.
:
:
---Return to continue, q to quit---

At the prompt, I key 'q' but it doesn't quit. The help text continue to list out help information.

[stonebig]

Hello,

On windows vista 32bit, ipython1.0 , python3 , If I patch core\page.py to try to see what happens, I get a 'byte' to 'string' message "Can't convert 'bytes' object to str implicitly".

==> Isn't it the issue for the test that searches for a "q" answer never succeeding ?

C:\Users\parent\Desktop\winpython\WinPython-32bit-3.3.2.2\python-3.3.2\lib\site-
packages\IPython\core\page.py in page_more()
307 io.stdout.write('---Return to continue, q to quit---')
308 ans = msvcrt.getch()
--> 309 io.stdout.write('---'+ans+'---')
310 ans = msvcrt.getch()
311 if ans in ("q", "Q"):

TypeError: Can't convert 'bytes' object to str implicitly

[takluyver]

Well found, @stonebig . It looks like msvcrt.getch() returns a byte b'q', which is not the same as a string 'q' on Python 3. Do you want to make a pull request to fix it?

[stonebig]

Hi,

I would prefer you do it, if possible.

[takluyver]

@stonebig : OK, can you test PR #4084? I'm not on Windows.