Remove python3 profile #1603
Merged
Remove python3 profile #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems sensible to me. |
|
Thanks, Min. I'll merge it later unless I hear objections. |
|
Looks good, thanks @takluyver! Merging now to keep the queue moving... |
fperez
added a commit
that referenced
this pull request
Apr 15, 2012
Remove python3 profile, which isn't really necessary. I also had a test failure because list_bundled_profiles() was seeing __pycache__ as a profile, so that's fixed.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Remove python3 profile, which isn't really necessary. I also had a test failure because list_bundled_profiles() was seeing __pycache__ as a profile, so that's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously defaulted to a separate profile for Python 3, then we decided we didn't need it. So this just scraps the profile folder.
I also had a test failure because list_bundled_profiles() was seeing
__pycache__as a profile, so that's fixed.