Small fixes for Animation and Progress notebook #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sensible enough, thanks! |
minrk
added a commit
that referenced
this pull request
Apr 15, 2012
Small fixes for Animation and Progress notebook use explicit integer division and don't rely on pylab_import_all
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Small fixes for Animation and Progress notebook use explicit integer division and don't rely on pylab_import_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new progress notebook example works nicely.
However there are two minor issues,
When from future import division is used
len(self.prog_bar) / 2is not an integer so I changed it tolen(self.prog_bar) // 2In addition but less important when pylab_import_all is False linspace is not in the global name space
so I changed that to np.linspace