don't rely on timedelta.total_seconds in AsyncResult #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is new in 2.7 Could result in weird errors, because the result was an AttributeError raised in a property, which triggered the `__getattr__()` path, which would also fail.
|
Great, thanks for the fix! |
|
Merging now. |
fperez
added a commit
that referenced
this pull request
Apr 16, 2012
don't rely on timedelta.total_seconds in AsyncResult (timedelta is new in python 2.7). This maintains compatibility with Python 2.6; the utility function introduced can be removed if/when we drop 2.6 support.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
don't rely on timedelta.total_seconds in AsyncResult (timedelta is new in python 2.7). This maintains compatibility with Python 2.6; the utility function introduced can be removed if/when we drop 2.6 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is new in 2.7
Could result in weird errors, because the result was
an AttributeError (on timedelta) raised in a property, which triggered
the
__getattr__()path, which would also fail.