New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Image in Qtconsole #1614
Comments
embed should be False if a url is given, because that means the display data need only be Another solution would be to enable support for |
But I think you make a good point that a note should be added that the QtConsole only supports embedded images. |
Well, there is still the problem that having embeded=False For URL make the image disapearing if there is no internet connexion, if it's removed...etc I would change the behavior to In fine this is your call, but that how I feel for using If it's a question of size of the notebook, I don't think an image will make much difference in size with lot of graph embeded. |
This seems pretty reasonable to me. From the notebook's perspective, I still think when an Image is given by URL, it rarely is actually desirable to embed the image, which has several disadvantages (in size, elegance, performance, etc.). But if this has to be done with The costs of this change:
The benefits:
|
hum...
Any idea why ? I tried specifying the |
Embed image as default to work in qtconsole unless url kwarg is set explicitely fixes ipython#1614
hi,
playing with
notebook_00
code in qtconsole I saw that :Does not display the image in qtconsole
It seems that it works by setting
embed=True
as a kwarg, but the docstring state that (emphase mine):Which don't give any clue as wether
embed
is needed for other frontend than notebook.Moreover 'if a filename' seem to mean that if the (first) argument given to
Image
is a filename, the embed is automaticaly set to true, whereas the code setembed
toTrue
if and only if thefilename **kwarg**
is notNone
.I suggest setting embed to True after
super
as been initiated if eitherself.filename
orself.url
are notNone
to be able to display the Image in QtConsole by just dooingImage(url or filename)
. Unless of course there is a good reason not to...The text was updated successfully, but these errors were encountered: