Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: QApplication doesn't quit early enough with PySide. #1631

Merged
merged 1 commit into from Apr 19, 2012
Merged

TST: QApplication doesn't quit early enough with PySide. #1631

merged 1 commit into from Apr 19, 2012

Conversation

punchagan
Copy link
Contributor

Fixes #1628. This commits adds a check in tests, to see if there's
already a QApplication and use it, instead of creating a new one each
time.

Fixes #1628.  This commits adds a check in tests, to see if there's
already a QApplication and use it, instead of creating a new one each
time.
@fperez
Copy link
Member

fperez commented Apr 19, 2012

Great, thanks for the quick reply @punchagan! I'll leave it to @jdmarch and you guys to test this one, since I'm not using pyside. @minrk also saw the breakage, so he might want to pitch in.

@jdmarch
Copy link

jdmarch commented Apr 19, 2012

Looks good. Broken qtconsole tests now pass with pyside 1.1.0-2 and pyqt on WinXP, Win7, and OSX 10.6.

@fperez
Copy link
Member

fperez commented Apr 19, 2012

Great, thanks. If you want to merge, go ahead... Quick summary of tips for merging:

  • use the "Merge pull request" button.
  • in the blue area, start by copy/pasting the description from the top of the PR. That's typically a good message for the whole PR, though you want to edit it manually to read better, add any other info from the discussion, remove unnecessary detail, etc. But it's a good start.
  • to copy the PR message, click on 'edit' at the top, so you can copy the raw markdown instead of the rendered text. That will make things like bullet lists read better in text.
  • don't forget to add at the end "Closes #NN, closes #mm,..." for any tickets the PR may close.

I'd rather you get the swing of it so we can better scale this process :)

jdmarch pushed a commit that referenced this pull request Apr 19, 2012
TST: QApplication doesn't quit early enough with PySide

In both tests which create a QApplication, first check whether one already exists, and if so use it. This is an issue with PySide, which unlike PyQt does not delete the QApplication when expected.

Closes #1628
@jdmarch jdmarch merged commit 9e4479b into ipython:master Apr 19, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
…st-error

TST: QApplication doesn't quit early enough with PySide

In both tests which create a QApplication, first check whether one already exists, and if so use it. This is an issue with PySide, which unlike PyQt does not delete the QApplication when expected.

Closes ipython#1628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: QApplication already exists in TestKillRing
3 participants