Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked commits from 0.12.1 release #1642

Merged
merged 15 commits into from Apr 27, 2012
Merged

Conversation

fperez
Copy link
Member

@fperez fperez commented Apr 22, 2012

At release time, there are always a bunch of little things that I end up fixing, and it's not practical to hold up the actual release to review them (we'd never release, basically). But now that 0.12.1 is out, it's worth reviewing those changes for 0.13, since we're in no hurry. I applied only the commits I made today during the release work, so most of this should be very safe.

required though. More information about :mod:`setuptools` can be found on its
website.
the most simple method of installing IPython and its dependencies. More
information about :mod:`distribute` can be found on its website.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should its website be a link?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, fixing now (to actually read 'on its PyPI page', with link, since that seems to be the authoritative site).

@fperez
Copy link
Member Author

fperez commented Apr 22, 2012

I'm actually going to rebase the PR to avoid having setup2/3 show up at all. Will do it here and will push shortly.

@minrk
Copy link
Member

minrk commented Apr 22, 2012

You might want to also include:

0a38298 (minified js note, updated with 0.13 versions)

and

d2deb47 (ignore gzip manpages)

@fperez
Copy link
Member Author

fperez commented Apr 23, 2012

Thanks for the tip, will do. Right now I got some conflicts on the rebase, so I'm cleaning that up.

@fperez
Copy link
Member Author

fperez commented Apr 23, 2012

OK, rebased to avoid resurrecting setup2/3 unnecessarily, and cherry-picked your suggestions above. Addressed other points I knew how to handle (I don't know to create a meta-target 'all' for setuptools dependencies).

@@ -2,7 +2,7 @@
"""Release data for the IPython project."""

#-----------------------------------------------------------------------------
# Copyright (c) 2008-2011, IPython Development Team.
# Copyright (c) 2008-2012, IPython Development Team.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to #1644 this should now be 2008 only... :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, might as well fix that now since I am changing that file, thanks. In my defense, I wrote this before we had the discussion :)

@minrk
Copy link
Member

minrk commented Apr 27, 2012

So copyright date is the only thing between this and merge, right?

@fperez
Copy link
Member Author

fperez commented Apr 27, 2012

Done, pushed.

@minrk
Copy link
Member

minrk commented Apr 27, 2012

Thanks, looks good. Merging.

minrk added a commit that referenced this pull request Apr 27, 2012
Cherry-picked commits from 0.12.1 release

Principally documentation and build/release tweaks.
@minrk minrk merged commit 2c1aa63 into ipython:master Apr 27, 2012
@fperez
Copy link
Member Author

fperez commented Apr 27, 2012

Great, thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Cherry-picked commits from 0.12.1 release

Principally documentation and build/release tweaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants