add patch_pyzmq() for backporting a few changes from newer pyzmq #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* missing constants in pyzmq < 2.1.9 * avoid jsonlib with pyzmq < 2.2.0
ensures patch_pyzmq() has been applied before any containing files are imported.
|
Looks great and clean, thanks! Merging now. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add patch_pyzmq() for backporting a few changes from newer pyzmq * fixes missing constants in super-old pyzmq * define ioloop.install if not defined * never allow jsonlib to be used by zmq.utils.jsonapi (ipython#1520). Closes ipython#1520.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last one should close #1520