Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure in IPython.zmq #1653

Closed
takluyver opened this issue Apr 24, 2012 · 4 comments · Fixed by #1656
Closed

Test failure in IPython.zmq #1653

takluyver opened this issue Apr 24, 2012 · 4 comments · Fixed by #1656
Labels
bug
Milestone
0.13

Comments

@takluyver
Copy link
Member

Our test suites failed today with this traceback:

Traceback (most recent call last):
  File "/sp/lib/python/cpython-2.7/lib/python2.7/unittest/case.py", line 356, in run
    self.tearDown()
  File "/home/slave/jenkins/shiningpanda/jobs/04a2e2a5/virtualenvs/ff035a1d/lib/python2.7/site-packages/zmq/tests/__init__.py", line 71, in tearDown
    raise RuntimeError("context could not terminate, open sockets likely remain in test")
RuntimeError: context could not terminate, open sockets likely remain in test

https://jenkins.shiningpanda.com/ipython/job/ipython/82/testReport/IPython.zmq.tests.test_session/TestSession/test_args/
@fperez
Copy link
Member

fperez commented Apr 24, 2012

Mmh, odd. I don't see the failure on my box (ubuntu 11.10).

@fperez
Copy link
Member

fperez commented Apr 24, 2012

@minrk, can you reproduce this anywhere?

@minrk
Copy link
Member

minrk commented Apr 24, 2012

Yep, it's the embeded kernel tests not cleaning up sockets. PR imminent.

@minrk minrk mentioned this issue Apr 24, 2012
Merged
@minrk
Copy link
Member

minrk commented Apr 24, 2012

PR #1656 should fix

@minrk minrk closed this as completed in 8bfca10 Apr 27, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#1656 from minrk/embed_kernel_tests
2f886ae 
ensure kernels are cleaned up in embed_kernel tests

use contextmanager to ensure kernel manager sockets are closed at the end of tests, preventing delayed 'could not close sockets' errors in later tests.

closes ipython#1653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

ensure kernels are cleaned up in embed_kernel tests minrk/ipython
3 participants
@fperez @minrk @takluyver