deprecate IPYTHON_DIR in favor of IPYTHONDIR #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,7 +260,10 @@ def get_ipython_dir(): | |||
| xdg_dir = get_xdg_dir() | |||
|
|
|||
| # import pdb; pdb.set_trace() # dbg | |||
| ipdir = env.get('IPYTHON_DIR', env.get('IPYTHONDIR', None)) | |||
| if 'IPYTHON_DIR' in env: | |||
| warnings.warn('The environment variable IPYTHON_DIR is depreciated. ' | |||
|
Looks sensible to me, after fixing the little typos that we are deprecating the variable, not depreciating it. |
|
Spelling fixed (force push, sorry), and a new commit describing the history of the variable. |
|
Thanks! And no worries about force push - it's always okay to force-push to a PR, I do it to fix spelling errors or rewrite commit messages all the time. |
minrk
added a commit
that referenced
this pull request
May 4, 2012
deprecate IPYTHON_DIR in favor of IPYTHONDIR IPYTHON_DIR was a proposed rename, whose added complexity does not outweigh any potential benefit, and is reverted. closes #1167
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
deprecate IPYTHON_DIR in favor of IPYTHONDIR IPYTHON_DIR was a proposed rename, whose added complexity does not outweigh any potential benefit, and is reverted. closes ipython#1167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1167.