fix Magic menu in qtconsole, split in groups #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
|
| magic_list = [] | ||
| for m_type, m_list in self.magics.iteritems() : | ||
| for m_name, mgc in m_list.iteritems(): | ||
| magic_list.append({'name':m_name, 'type':m_type, 'class':mgc.im_class.__name__}) |
There was a problem hiding this comment.
mgc may be just a function here, in which case this will raise AttributeError on im_class. To see this, simply run this block in the qtconsole on master, where %guiref is such a magic.
Rearrange magics in menu, organize as submenu based on class of magic
|
Thanks, fixed, rebased and squashed to have cleaner commits. |
|
Does anybody ave something agains me merging it ? |
|
merging then... |
Carreau
added a commit
that referenced
this pull request
Jun 6, 2012
fix Magic menu in qtconsole, split in groups
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix Magic menu in qtconsole, split in groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #1774
alternative to #1776, that also reorganize magic in several menu.
Menu name is decided by inserting space in the CamelCasse name of the class of the magic.
Moreover, if there is a way to know if the magic have to take argument or not (
%logstatevs%timeit),I could tweak the menu to either execute, or to paste the magic at the beginning of the curent line.