Fixed a vcvarsall.bat error on win32/Py2.7 when trying to compile with m... #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @dhirschfeld . |
|
This looks good to me code-wise, and since we don't have a win32/mingw machine to test on, we'll go with your report that it helps until further notice. Thanks a lot for contributing the fix! I'll merge it now. |
fperez
added a commit
that referenced
this pull request
May 31, 2012
Fixes Cython compilation errors on certain Windows/mingw configurations.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…s-fix Fixes Cython compilation errors on certain Windows/mingw configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same error as cython pull request 129.
cython/cython#129
This makes
%cythonalso work for me but the cython devs have yet to confirm that this is the correct fix.