add missing cython exclusion in iptest #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is the right fix. Merging now. |
fperez
added a commit
that referenced
this pull request
May 31, 2012
add missing cython exclusion in iptest
|
Thanks for tracking this down! |
|
It may not be worth it, but do we want to add warnings so nonexistent exclusions (like the incredibly common 'tests/test' typo that was frustrating Fernando) are apparent? |
|
I was just thinking that... It will also help us remove stale exclusions as code gets refactored and moved around... |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add missing cython exclusion in iptest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension itself was excluded, but the test file was not.
closes #1802