Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn on nonexistent exclusions in iptest #1811

Merged
merged 3 commits into from May 31, 2012
Merged

warn on nonexistent exclusions in iptest #1811

merged 3 commits into from May 31, 2012

Conversation

minrk
Copy link
Member

@minrk minrk commented May 31, 2012

Adds a simple check in iptest that warns if any exclusions point to nonexistent files.

And removes a few stale exclusions revealed on first run.

@fperez
Copy link
Member

fperez commented May 31, 2012

I'm getting spurious warnings:

WARNING: Excluding nonexistent file: 'IPython/external'
WARNING: Excluding nonexistent file: 'IPython/quarantine'
WARNING: Excluding nonexistent file: 'IPython/deathrow'
WARNING: Excluding nonexistent file: 'IPython/testing/mkdoctests'
WARNING: Excluding nonexistent file: 'IPython/lib/inputhook'
WARNING: Excluding nonexistent file: 'IPython/config/profile'
WARNING: Excluding nonexistent file: 'IPython/lib/inputhookgtk'
WARNING: Excluding nonexistent file: 'IPython/zmq/gui/gtkembed'

and several (maybe all) of those do exist for sure.

@minrk
Copy link
Member Author

minrk commented May 31, 2012

I missed that because I was running from the IPython dir. Should be fixed.

@fperez
Copy link
Member

fperez commented May 31, 2012

Test results for commit b4ea219 merged into master
Platform: linux2

  • python2.7: OK (libraries not available: wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib pymongo qt tornado wx wx.aui zmq)

Not available for testing:

@fperez
Copy link
Member

fperez commented May 31, 2012

Looks great now, thanks! Merging.

fperez added a commit that referenced this pull request May 31, 2012
@fperez
Merge pull request #1811 from minrk/exclusions
e605f72 
Warn on nonexistent exclusions in iptest.  This will help us avoid common and often baffling errors from simple typos, as well as keeping the exclusions list updated as the code evolves.
@fperez fperez merged commit e605f72 into ipython:master May 31, 2012
@minrk minrk deleted the exclusions branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@fperez
Merge pull request ipython#1811 from minrk/exclusions
5d2fd44 
Warn on nonexistent exclusions in iptest.  This will help us avoid common and often baffling errors from simple typos, as well as keeping the exclusions list updated as the code evolves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minrk @fperez @jdmarch