Always use filename as the notebook name. #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, and seems sensible to me. Ready for merge? |
|
Sure, merge away. On Thu, May 31, 2012 at 4:56 PM, Min RK
Brian E. Granger |
ellisonbg
added a commit
that referenced
this pull request
Jun 1, 2012
Always use filename as the notebook name.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Always use filename as the notebook name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the filename and notebook name (in the JSON data) were in conflict, we used to use the JSON data. This was leading to problems as described in #1593. This fixes the problem so that the filename is always used. Subsequent saves will also set the JSON name to be the same value.