Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resubmitted tasks doesn't have same session name #1834

Closed
kaazoo opened this issue Jun 1, 2012 · 5 comments · Fixed by #1836
Closed

resubmitted tasks doesn't have same session name #1834

kaazoo opened this issue Jun 1, 2012 · 5 comments · Fixed by #1836
Labels
parallel
Milestone
0.13

Comments

@kaazoo
Copy link

kaazoo commented Jun 1, 2012

If I understand correctly, a task gets a new msg_id when you call client.resubmit(msg_id). I noticed that the 'cloned' task seems to have a random session name. I would suggest to take over all cutomizable attributes: session, username, retries, after, ... in order to let the resubmitted task behave like the original one.

One side effect for me would be to delete the original task after the resubmitted one took it's place.
@minrk
Copy link
Member

minrk commented Jun 1, 2012

The new session is not random, it's that of the Hub, the submitter of the new task.

But I think you are right, it should start with the same header, and replace only the msg_id and timestamps.

@kaazoo
Copy link
Author

kaazoo commented Jun 1, 2012

Yes, that would be cool.

@minrk minrk mentioned this issue Jun 2, 2012
Merged
@minrk
Copy link
Member

minrk commented Jun 2, 2012

try: #1836

@kaazoo
Copy link
Author

kaazoo commented Jun 2, 2012

OK, seems to work. The resubmitted tasks now have the same session name.

@kaazoo kaazoo closed this as completed Jun 2, 2012
@fperez fperez reopened this Jun 2, 2012
@fperez
Copy link
Member

fperez commented Jun 2, 2012

Reopening until the actual PR is merged. I'll have a look now.

@minrk minrk closed this as completed in ba8a569 Jun 2, 2012
Carreau pushed a commit to Carreau/ipython that referenced this issue Jun 3, 2012
@fperez
Merge pull request ipython#1836 from minrk/resumbithead
99da83b 
Preserve header for resubmitted tasks (aside from new msg_id and timestamp).

Also fixes a DictDB clobbering bug.

Closes ipython#1834.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
preserve header for resubmitted tasks
b9f85c6 
header should be unchanged, aside from the msg_id and timestamp

closes ipython#1834
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@fperez
Merge pull request ipython#1836 from minrk/resumbithead
e837702 
Preserve header for resubmitted tasks (aside from new msg_id and timestamp).

Also fixes a DictDB clobbering bug.

Closes ipython#1834.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parallel
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

preserve header for resubmitted tasks minrk/ipython
3 participants
@fperez @minrk @kaazoo