use glob for bad exclusion warning #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than explicit check for .py closes ipython#1896
|
This will fix it, but is it the right fix? Is it too broad? Or should the exclusion mechanism be forced to specify explicit extension for non-py files? |
|
@jdmarch, let us know if this works for you, and thanks for catching that! |
jdmarch
pushed a commit
that referenced
this pull request
Jun 11, 2012
use glob for bad exclusion warning rather than explicit check for .py closes #1896
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use glob for bad exclusion warning rather than explicit check for .py closes ipython#1896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than explicit check for .py
closes #1896