Workaround fix for gh-1632; minimal revert of gh-1424 #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Win32 shell interactivity broke qtconsole cd magic
|
This seems like a very clean, localized fix, and we trust you on the hands-on battle with Win32, so I'm merging it now. Given that it addresses a blocker, this is pretty high-value for such a small fix... Thanks for getting on it despite your crazy schedule! |
This was referenced Jun 11, 2012
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Workaround fix for ipythongh-1632, using a minimal revert of ipythongh-1424. Win32 shell interactivity broke qtconsole cd magic, this restores it. closes ipython#1632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Win32 shell interactivity broke qtconsole cd magic
closes #1632