Use oinspect in CodeMagics._find_edit_target #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspect.getabsfile and inspect.getsourcelines are replaced by find_file and find_source_lines in IPython.core.oinspect.
|
Code looks clean, running test_pr now. Will merge if all tests are OK. Thanks!! |
|
Test results for commit e036834 merged into master
Not available for testing: |
|
Clean tests, merging now. Thanks! |
fperez
added a commit
that referenced
this pull request
Jun 11, 2012
Use oinspect in CodeMagics._find_edit_target inspect.getabsfile and inspect.getsourcelines are replaced by find_file and find_source_lines in IPython.core.oinspect, which is our own more robust code that wraps the default one from the stdlib.
|
Wow. That's super quick. Thank you very much! BTW, I couldn't find any tests for CodeMagics by simply grep'ing the source code when I wrote the patch. Does test cover the code I wrote? |
|
The state of magics testing is fairly uneven, so any tests you contribute on this front will be very welcome (and are likely to uncover new bugs ;) |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Use oinspect in CodeMagics._find_edit_target inspect.getabsfile and inspect.getsourcelines are replaced by find_file and find_source_lines in IPython.core.oinspect, which is our own more robust code that wraps the default one from the stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspect.getabsfile and inspect.getsourcelines are replaced by find_file and find_source_lines in IPython.core.oinspect.
Except the change of the functions, changed code is roughly equivalent to the previous one. But the changed code tries to find method in non-fake module more than previous one. I think it's OK since the failed case is caught in the next
if filename is None:block anyway. As I am not completely sure what _find_edit_target (%edit) does, maybe there are something missing.