Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make completer recognize escaped quotes in strings. #1926

Merged
merged 1 commit into from Jun 12, 2012
Merged

Make completer recognize escaped quotes in strings. #1926

merged 1 commit into from Jun 12, 2012

Conversation

int3
Copy link
Contributor

@int3 int3 commented Jun 12, 2012

The func_kw completer, to be precise.

@takluyver
Copy link
Member

A negative lookbehind assertion, that's fancy ;-).

It looks good, I'm just running the tests now.

@takluyver
Copy link
Member

Test results for commit 8d23a43 merged into master
Platform: linux2

  • python2.7: OK (libraries not available: pymongo wx wx.aui)
  • python3.2: OK (libraries not available: pymongo wx wx.aui)

Not available for testing: python2.6, python3.1

@int3
Copy link
Contributor Author

int3 commented Jun 12, 2012

A negative lookbehind assertion, that's fancy ;-).

Heh, picked it up from working with Vim syntax highlighting files.

Thanks for the quick response!

@takluyver
Copy link
Member

No worries. As we're trying to stabilise things for a 0.13 release, I'll let @fperez look over it once their timezone is awake, but I think it will be OK to go in.

@fperez
Copy link
Member

fperez commented Jun 12, 2012

Yes, this is totally in the 'spit and polish' category of things we do want in for a really solid and nice-looking 0.13.

@takluyver
Copy link
Member

Alright, merging this now. Thanks, @int3 .

takluyver added a commit that referenced this pull request Jun 12, 2012
Make completer recognize escaped quotes in strings.
@takluyver takluyver merged commit bb59edd into ipython:master Jun 12, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Make completer recognize escaped quotes in strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants