oinspect.find_file: Additional safety if file cannot be found. #1933
Conversation
In some code paths, e.g. when introspecting fortran objects generated by f2py, oinspect.find_file will raise an UnboundLocalError. Prevent this by setting fname to None.
|
Is there any reasonable way to have a self-contained test for this? |
|
Test results for commit b570c26 merged into master
Not available for testing: python2.6, python3.1 |
|
@bfroehle, if you think you can easily add an extra test that catches the problem, that would be great. Otherwise this can go in as-is, given it's such a tiny amount of code and fairly obvious by inspection. |
|
It's unclear to me how we could test this without a compiler being present. I checked the NumPy source (where f2py lives) but by default there aren't any modules compiled using f2py. Additionally it doesn't seem to be possible to instantiate a 'fortran' object. But, if you want to play around I started a gist at https://gist.github.com/2920793 |
|
Nah, not worth burning the cycles for such a simple fix. We have bigger fish to fry. Merging now. Thanks!! |
oinspect.find_file: Additional safety if file cannot be found. In some code paths, e.g. when introspecting fortran objects generated by f2py, oinspect.find_file will raise an UnboundLocalError. Prevent this by setting fname to None.
oinspect.find_file: Additional safety if file cannot be found. In some code paths, e.g. when introspecting fortran objects generated by f2py, oinspect.find_file will raise an UnboundLocalError. Prevent this by setting fname to None.
In some code paths, e.g. when introspecting fortran objects generated by f2py,
oinspect.find_filewill raise an UnboundLocalError. Prevent this by setting fname to None.