Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow path completion on notebook. #1974

Merged
merged 1 commit into from Jun 20, 2012
Merged

Allow path completion on notebook. #1974

merged 1 commit into from Jun 20, 2012

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Jun 16, 2012

add -(dash) /(slash) (antislash for windows) : (colon) ~(tilde)
as part of words symbol for notebook completer to help for path
completion

Fixes #1969

@ivanov does it fixes all your issues ? do you see any more characters that should be added, or some that can cause any trouble ?

@ivanov
Copy link
Member

ivanov commented Jun 16, 2012

unfortunately, this makes things worse :-\

it doesn't fix completions for ls ./<tab>, but now breaks completions for ls a<tab> (when there are files that start with a)

@Carreau
Copy link
Member Author

Carreau commented Jun 16, 2012

Hum, FF on debian can't seem to be able to parse the regexp anymore, Chrome did it on OSX without problem 2h ago...I'll investigate tomorow.

@Carreau
Allow path completion on notebook.
d6b9c94 
add -(dash) /(slash) \(antislash for windows) : (colon) ~(tilde)
as part of words symbol for notebook completer to help for path
completion

Fixes ipython#1969
@Carreau
Copy link
Member Author

Carreau commented Jun 17, 2012

One more try. I made a leap of faith adding : and \ for windows but I'm not sure it works.

@Carreau
Copy link
Member Author

Carreau commented Jun 19, 2012

Did you had a chance to test it again ?

@ivanov
Copy link
Member

ivanov commented Jun 19, 2012

@Carreau it does work, thanks! I'm fine with merging this. It has an unexpected "feature" that just \ or : followed by <tab> triggers a whole bunch of possible completions. However, this is not unique to the notebook interface, as it turns out in plain old ipython and qtconole also have this behavior, so that's a separate issue.

@Carreau
Copy link
Member Author

Carreau commented Jun 20, 2012

Don't tell me you never complete path on your C:\ drive... merging then.

Carreau added a commit that referenced this pull request Jun 20, 2012
@Carreau
Merge pull request #1974 from Carreau/notebook-path-completion
cd6a827 
Allow path completion on notebook.
add slash (/) for unix,  backslash (\) and colon (:) for windows
as authorized characters in completions.
@Carreau Carreau merged commit cd6a827 into ipython:master Jun 20, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@Carreau
Merge pull request ipython#1974 from Carreau/notebook-path-completion
4ee10f5 
Allow path completion on notebook.
add slash (/) for unix,  backslash (\) and colon (:) for windows
as authorized characters in completions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

tab completion in notebook for paths not triggered
2 participants
@Carreau @ivanov