Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook should check that --notebook-dir exists #1980

Closed
Carreau opened this issue Jun 18, 2012 · 2 comments
Closed

Notebook should check that --notebook-dir exists #1980

Carreau opened this issue Jun 18, 2012 · 2 comments
Milestone
0.13

Comments

@Carreau
Copy link
Member

Carreau commented Jun 18, 2012

otherwise the UI is confusing, it works but jus refuses to upload files.
@tkf
Copy link
Contributor

tkf commented Jun 18, 2012

An option for creating the directory if it is not there would be nice.

@fperez
Copy link
Member

fperez commented Jun 18, 2012

Furthermore, kernels should be started in the notebook dir when specified. Otherwise it's kind of useless that one has to manually cd first into the directory one wants kernels to pop up as. I should probably open this as a separate issue though...

@minrk minrk mentioned this issue Jun 20, 2012
Merged
@minrk minrk closed this as completed in e9806d2 Jun 20, 2012
minrk added a commit to minrk/ipython that referenced this issue Jun 21, 2012
@minrk
Merge pull request ipython#1951 from minrk/nbdir
cf79ff2 
minor notebook startup/notebook-dir adjustments

* change inaccurate / distressing "Overwriting profile..." log message
* `ipython notebook path` results in setting notebook-dir if it's a dir,
  rather than unconditionally setting file-to-run
* file-to-run overrides no-browser
* kernels start in the notebook dir, rather than the Server's cwd
* notebook dir is validated, and created if it doesn't exist (only if parent exists, like ~all other such things)

closes ipython#1985
closes ipython#1980
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
create notebook-dir if it doesn't exist
50bf3b9 
closes ipython#1980
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
Merge pull request ipython#1951 from minrk/nbdir
4f824ee 
minor notebook startup/notebook-dir adjustments

* change inaccurate / distressing "Overwriting profile..." log message
* `ipython notebook path` results in setting notebook-dir if it's a dir,
  rather than unconditionally setting file-to-run
* file-to-run overrides no-browser
* kernels start in the notebook dir, rather than the Server's cwd
* notebook dir is validated, and created if it doesn't exist (only if parent exists, like ~all other such things)

closes ipython#1985
closes ipython#1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
4 participants
@tkf @fperez @minrk @Carreau