Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernels should start in notebook dir when manually specified #1985

Closed
fperez opened this issue Jun 18, 2012 · 2 comments · Fixed by #1951
Closed

Kernels should start in notebook dir when manually specified #1985

fperez opened this issue Jun 18, 2012 · 2 comments · Fixed by #1951

Comments

@fperez
Copy link
Member

fperez commented Jun 18, 2012

Right now the --notebook-dir flag only sets the saving directory, but kernels still start wherever the notebook process was started. For consistency, if the notebook dir flag was given, it should also apply to the kernel directories, otherwise it's a bit useless, and makes it clumsy to run isolated servers configured with directories for their own profiles.

This is easy but I think we should make it a blocker for 0.13 so that there's at least some consistent mechanism for mild user isolation out of the box.

@minrk
Copy link
Member

minrk commented Jun 18, 2012

See PR #1951

@fperez
Copy link
Member Author

fperez commented Jun 18, 2012

Your time machine is even better than mine!

@minrk minrk closed this as completed in cf79ff2 Jun 20, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
minor notebook startup/notebook-dir adjustments

* change inaccurate / distressing "Overwriting profile..." log message
* `ipython notebook path` results in setting notebook-dir if it's a dir,
  rather than unconditionally setting file-to-run
* file-to-run overrides no-browser
* kernels start in the notebook dir, rather than the Server's cwd
* notebook dir is validated, and created if it doesn't exist (only if parent exists, like ~all other such things)

closes ipython#1985
closes ipython#1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants