notebook: Print a warning (but do not abort) if no webbrowser can be found. #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -569,7 +570,8 @@ def start(self): | |||
| b = lambda : browser.open("%s://%s:%i%s%s" % (proto, ip, | |||
| self.port, self.base_project_url, url), | |||
| new=2) | |||
| threading.Thread(target=b).start() | |||
| if browser: | |||
There was a problem hiding this comment.
Almost perfect, I'd just move this if clause above the lambda so that we don't even bother declaring b when browser is None.
|
Sure. Force pushed an update. I avoided it before because the indentation got pretty funky. |
|
Great, thanks. Merging now. |
fperez
added a commit
that referenced
this pull request
Jun 23, 2012
notebook: Print a warning (but do not abort) if no webbrowser can be found. Closes gh-2006.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
notebook: Print a warning (but do not abort) if no webbrowser can be found. Closes ipythongh-2006.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-2006.