Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook server can't start cluster with hyphen-containing profile name #2011

Closed
tkf opened this issue Jun 23, 2012 · 0 comments · Fixed by #2014
Closed

Notebook server can't start cluster with hyphen-containing profile name #2011

tkf opened this issue Jun 23, 2012 · 0 comments · Fixed by #2014
Labels
notebook
Milestone
0.13

Comments

@tkf
Copy link
Contributor

tkf commented Jun 23, 2012

Notebook server can't start cluster of the profile which name contains non-alphabetical and non-numeric characters such as -. This is because of the regex defined in notebookapp._profile_regex:

_profile_regex = r"(?P<profile>[a-zA-Z0-9]+)"

See: notebookapp._profile_regex

Probably this regex should allow anything other than slashes? At least I think it's better to add _ and -.
@minrk minrk mentioned this issue Jun 23, 2012
Merged
@minrk minrk closed this as completed in 4c8a662 Jun 23, 2012
jdmarch pushed a commit to jdmarch/ipython that referenced this issue Jun 24, 2012
@fperez
Merge pull request ipython#2014 from minrk/profile_re
7415e59 
Relax profile regex in notebook.  Almost any text is a valid profile name, and the previous code only included ascii alphanumeric strings.

closes ipython#2011.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk
relax profile regex in notebook
a23923e 
Almost any text is a valid profile name, and the previous code
only included ascii alphanumeric strings.

closes ipython#2011
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@fperez
Merge pull request ipython#2014 from minrk/profile_re
a45bdc1 
Relax profile regex in notebook.  Almost any text is a valid profile name, and the previous code only included ascii alphanumeric strings.

closes ipython#2011.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
notebook
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

relax profile regex in notebook minrk/ipython
2 participants
@tkf @minrk