Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel test on WinXP - wait for resource cleanup. #2025

Merged
merged 2 commits into from Jun 24, 2012

Conversation

jdmarch
Copy link

@jdmarch jdmarch commented Jun 24, 2012

Fixes #1901

@takluyver
Copy link
Member

Does setUp run before every test? There's quite a few in that class, so if it's an extra 2s delay on each, it would be quite a slowdown. Is it needed before every test there?

@takluyver
Copy link
Member

Test results for commit bbc8619 merged into master
Platform: linux2

  • python2.7: Failed, log at https://gist.github.com/2983828 (libraries not available: oct2py rpy2)
  • python3.1: Failed, log at https://gist.github.com/2983829 (libraries not available: cython matplotlib numpy oct2py pymongo qt rpy2 wx wx.aui zmq)
  • python3.2: OK (libraries not available: cython oct2py pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

@jdmarch
Copy link
Author

jdmarch commented Jun 24, 2012

@takluyver -- yes, setUp runs before every test. It does not suffice to delay 2 sec before the first test where the fail happened (the failure migrates). More than that I don't have time to ascertain; it could take quite a bit of trial and error.

Also, recall that the delay will only happen on winXP -- on the available evidence, there are no auto-testers running XP.

@takluyver
Copy link
Member

OK, if it's necessary, that's fine. As you say, we don't have many XP testers.

I think we could do with a 'fast test' mode. I'll open a separate
issue for that.

@minrk
Copy link
Member

minrk commented Jun 24, 2012

@jdmarch - I think the sleep should probably happen before the rest of the setUp.

at minrk suggestion. Still fails at 1 sec sleep, so keeping 2 sec.
@minrk
Copy link
Member

minrk commented Jun 24, 2012

Since @jdmarch is our only known XP tester, and this shouldn't affect any non-XP systems, I think this is fine as a band-aid.

@minrk
Copy link
Member

minrk commented Jun 24, 2012

Test results for commit 2d449a4 merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pymongo qt rpy2 wx wx.aui)

Not available for testing: python3.1

minrk added a commit that referenced this pull request Jun 24, 2012
…leanup

Add a bunch of time.sleep to IPython.parallel tests on XP-only

Closes #1901
@minrk minrk merged commit b1eae24 into ipython:master Jun 24, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
…t_for_cleanup

Add a bunch of time.sleep to IPython.parallel tests on XP-only

Closes ipython#1901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: parallel test fails assert, leaves 14 python processes alive
3 participants