New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel test on WinXP - wait for resource cleanup. #2025
Fix parallel test on WinXP - wait for resource cleanup. #2025
Conversation
Does |
Test results for commit bbc8619 merged into master
Not available for testing: python2.6 |
@takluyver -- yes, setUp runs before every test. It does not suffice to delay 2 sec before the first test where the fail happened (the failure migrates). More than that I don't have time to ascertain; it could take quite a bit of trial and error. Also, recall that the delay will only happen on winXP -- on the available evidence, there are no auto-testers running XP. |
OK, if it's necessary, that's fine. As you say, we don't have many XP testers. I think we could do with a 'fast test' mode. I'll open a separate |
@jdmarch - I think the sleep should probably happen before the rest of the setUp. |
at minrk suggestion. Still fails at 1 sec sleep, so keeping 2 sec.
Since @jdmarch is our only known XP tester, and this shouldn't affect any non-XP systems, I think this is fine as a band-aid. |
Test results for commit 2d449a4 merged into master
Not available for testing: python3.1 |
…leanup Add a bunch of time.sleep to IPython.parallel tests on XP-only Closes #1901
…t_for_cleanup Add a bunch of time.sleep to IPython.parallel tests on XP-only Closes ipython#1901
Fixes #1901