Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match stdin encoding in frontend readline test #2027

Merged
merged 1 commit into from Jun 24, 2012
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Jun 24, 2012

previously DEFAULT_ENCODING was used, but that's not what we use when storing readline history.

closes #2023

@takluyver
Copy link
Member

DEFAULT_ENCODING should get the encoding from stdin (https://github.com/ipython/ipython/blob/master/IPython/utils/encoding.py) - why is that not working?

@takluyver
Copy link
Member

Ah, I see. DEFAULT_ENCODING gets stdin.encoding, but if that doesn't exist, and locale.getpreferredencoding() doesn't work, it falls back to sys.getdefaultencoding() - which is ascii for Python 2.

@takluyver
Copy link
Member

Would it make sense to make the actual code use DEFAULT_ENCODING, rather than making the test not use it? I'm not quite sure of the ramifications, though, so maybe it's best to fix the test for 0.13 and sort it out later.

@minrk
Copy link
Member Author

minrk commented Jun 24, 2012

I was just typing up pretty much exactly that :)

@minrk
Copy link
Member Author

minrk commented Jun 24, 2012

Test results for commit d4a7b66 merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pymongo qt rpy2 wx wx.aui)

Not available for testing: python3.1

@minrk
Copy link
Member Author

minrk commented Jun 24, 2012

Opened #2032 for the real fix later, and merging this as-is.

minrk added a commit that referenced this pull request Jun 24, 2012
match stdin encoding in frontend readline test

The real fix is probably the reverse, but should not be changed this close to release (see #2032).

closes #2023
@minrk minrk merged commit 7bab692 into ipython:master Jun 24, 2012
@minrk minrk deleted the stdin_enc branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
match stdin encoding in frontend readline test

The real fix is probably the reverse, but should not be changed this close to release (see ipython#2032).

closes ipython#2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unicode test failure on OS X
2 participants